Relaxed 304 If-None-Match test to support weak key #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drinkbeer
approved these changes
Mar 22, 2023
| # If-None-Match: "abc" | ||
| # If-None-Match: W/"abc" | ||
| # If-None-Match: "abc", "def" | ||
| if !@env["HTTP_IF_NONE_MATCH"].nil? && @env["HTTP_IF_NONE_MATCH"].include?(cache_key_hash) |
There was a problem hiding this comment.
Isn't that matching way too lose?
cache_key_hash = "b"
If-None-Match: W/"abc" shouldn't match IMO.
I think this method need actual parsing of the header, String#include? doesn't.
|
@colinbendell you didn't address my comment... |
|
Sorry! Missed this.
While you are strictly correct that a shortened INM will match an etag, the
reality is that the etag we generate are 128bit hashes. For this reason I
think practically speaking being more strict on the matches won’t yield any
real benefits. If a fraudulent INM is sent with a truncated etag value,
this might cause a 304, but this is a client misconfiguration issue and
won’t reveal any untoward information.
…On Thu, Mar 23, 2023 at 18:39 Jean byroot Boussier ***@***.***> wrote:
@colinbendell <https://github.com/colinbendell> you didn't address my
comment...
—
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMMERKLVBCKUUDREOIWJQDW5TGKHANCNFSM6AAAAAAWDHFPJA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I fixed it anyway: #66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP Requests with If-None-Match should support quoted, weak and arrays of entity tags. This PR enables a more generous match for eTags to increase 304 responses.
Specifically, given an
etag: abc123value, the followingif-none-matchrequests should yield a 304:if-none-match: abc123if-none-match: "abc123"if-none-match: W/"abc123"if-none-match: "abc123", "def456"