Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename cacheable to response_bank #42

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Rename cacheable to response_bank #42

merged 1 commit into from
Jan 27, 2020

Conversation

rafaelfranca
Copy link
Member

@rafaelfranca rafaelfranca commented Jan 20, 2020 •
edited
Loading

The cacheable gem is already taken on Rubygems, so we had to find a different name for this library.

@rafaelfranca rafaelfranca requested a review from a team as a code owner January 20, 2020 20:38
@rafaelfranca
Copy link
Member Author

I called response_bank but the description says it is a request cache, not sure which one is the correct.

@rafaelfranca rafaelfranca force-pushed the rm-rename-gem branch 2 times, most recently from 7cfab22 to cc74483 Compare January 20, 2020 20:45
burke
burke approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@burke burke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@pushrax
Copy link

pushrax commented Jan 20, 2020

I called response_bank but the description says it is a request cache, not sure which one is the correct.

This gem caches the response for a given request.. response cache seems more accurate to me.

@rafaelfranca
Rename cacheable to response_bank
7159740 
The cacheable gem is already taken on Rubygems, so we had to find a
different name for this library.
@rafaelfranca
Copy link
Member Author

Thank you @pushrax. I updated the summary of the gem.

@rafaelfranca rafaelfranca merged commit fe582f1 into master Jan 27, 2020
@rafaelfranca rafaelfranca deleted the rm-rename-gem branch January 27, 2020 22:18
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems August 4, 2021 15:57 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems July 18, 2022 08:46 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casperisfine casperisfine casperisfine approved these changes

@Edouard-chin Edouard-chin Edouard-chin approved these changes

@DerekStride DerekStride DerekStride approved these changes

@burke burke burke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rafaelfranca @pushrax @burke @DerekStride @Edouard-chin @casperisfine