Support React Native 0.73

[jahead]

Description

Currently testing this package on 0.73-rc.3 which might seem early - but if it's public it's ready for production... (:D joking)

I'm getting the error.

/Users/jahead/projects/bcs/BcsInspectionsMobileApp/node_modules/react-native/ReactCommon/react/renderer/components/image/ImageProps.h:8:10 'react/renderer/components/view/ViewProps.h' file not found

At first rn was not respecting the fabric flag for whether it should be on, see facebook/react-native#41284.
I applied the patch using package-patch and forced fabric to be disabled and the problem persisted.

You can track progress for the release here reactwg/react-native-releases#64

• Fabric is disabled
• Builds fine on android

Version

0.1.216

Steps to reproduce

1. npx react-native init RN073RC3 --version 0.73.0-rc.3
2. yarn add react-native-skia
3. apply patch described in Fix ios pod post_install logic for detecting if fabric is enabled facebook/react-native#41284
4. yarn
5. yarn run ios

Snack, code example, screenshot, or link to a repository

https://github.com/jahead/rn-skia-73-test

[jahead]

To be clear this is for react native 0.73.0 on the old architecture.

[wcandillon]

@jahead thanks of lot for bringing this up under our radar.

[jahead]

Hey @wcandillon, I'm just tracking the updates. rc.4 was released and I tested against the new release with #1961

Progress but now getting.

Obviously, if we don't care for paper now that fabric is support, we should close this?

[WoLewicki]

@jahead I think all libraries should definitely still support both architectures 😅 Do you want any help with debugging this or are you on a path to resolve the issue?

[jahead]

Hey, tbh we will probably just turn on fabric if possible as a solution once re-integrating skia on our 0.73.0 branch gets back to the top of my stack.

I will happily look into why the test project is broken though once i get home, and if I find a solution that requires a PR, I'll submit one. Though I'm not update to date with the JSI/Fabric changes in recent RN versions, so, we can only hope ;D

[WoLewicki]

Sure, let me know how it went and if I can help.

[jahead]

Found an issue. I'll post a PR

[jahead]

So an update. #1951 (comment)

Was due to currently react-native run-ios in the rc.4 doesn't run the dev server automatically. This is intended, and will likely be fixed when the cli is updated.

however once I ensured I was running the dev server, I was getting

error: node_modules/@shopify/react-native-skia/lib/module/specs/SkiaDrawViewNativeComponent.js: /Users/jahead/projects/open-source/RN073RC3/node_modules/@shopify/react-native-skia/lib/module/specs/SkiaDrawViewNativeComponent.js: Could not find component config for native component

Which react-native-web was also getting. You can trace the work done here reactwg/react-native-releases#64 (comment)

I've applied the same patch with #1981

[jahead]

with #1981 and 0.1.220 release this has resolved what seems to be all issues with 0.73.0-rc.4 builds.

I'm sure if you want to keep this open until 0.73.0 is released, but my simple tests are working.

[wcandillon]

I'm ok to close it for now, thank you for your support on this.