Remove dead method filter_versions!
#265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![shopify-codedb[bot]](https://avatars.githubusercontent.com/u/8085?s=60&v=4){kind=small}
|
This method is meant to be used by consumers of this gem. |
|
@egiurleo if this method is detected as dead, does that mean we have no test for it?
If this method is part of the public API it should be tested. |
|
@Morriar okay! I can open a PR for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method appears to be unused and could be removed.
Before approving this pull-request, please double-check that it is indeed unused.
filter_versions!on GitHubIf this code is actually used, please add a comment explaining why and close this pull-request.