Migrate parsing to YARP #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
added
enhancement
andyw8
reviewed
Sep 5, 2023
| spec.add_dependency("sorbet-runtime", ">= 0.5.9204") | ||
| spec.add_dependency("unparser", ">= 0.5.6") |
There was a problem hiding this comment.
Since YARP releases may contain breaking changes while still under develpment, should be put an upper limit on this?
There was a problem hiding this comment.
This may help us find and fix these bugs faster
andyw8
reviewed
Sep 5, 2023
| begin_line: yarp_location.start_line, | ||
| end_line: yarp_location.end_line, | ||
| begin_column: yarp_location.start_column, | ||
| end_column: yarp_location.end_column + 1, # TODO: Why is this off by one? |
There was a problem hiding this comment.
Known issue, I'm verifying Kevin's suggestion for a fix here.
There was a problem hiding this comment.
Great! I'm going to merge and update this once fixed 👍
|
I bumped YARP to 0.0.10 and tested the changes on core 👍 |
andyw8
approved these changes
Sep 7, 2023
andyw8
reviewed
Sep 7, 2023
test/rbi/parser_test.rb
Outdated
| assert_equal("unexpected token $end", e.message) | ||
| assert_equal("test_parse_real_file_with_error.rbi:2:0-2:0", e.location.to_s) | ||
| assert_equal("Expected to be able to parse an expression. Expected `end` to close `class` statement.", e.message) | ||
| # assert_equal("test_parse_real_file_with_error.rbi:1:10-1:10", e.location.to_s) |
There was a problem hiding this comment.
Yeah good idea. I commented it until we figure the weird locations returned by YARP but I can keep the wrong location in the assert instead
andyw8
reviewed
Sep 7, 2023
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been experimenting with different parser backends to benchmark RBI parsing.
Here are the time required to parse all the 11801 RBI files in on big project:
This PR migrates RBI parsing to YARP and removes the dependecy to Whitequark and
unparser.Running
tapioca check-shimsbefore (usingparsergem):Running
tapioca check-shimsafter (using YARP):