Bump Sorbet version and introduce AbstractParam #160
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
Param
class plays 2 roles:However, after sorbet/sorbet#6273 Sorbet stops prohibiting instantiating abstract classes, which means these 2 roles can't co-exist on the same calss anymore.
I think that leaves us with 2 options:
AbstractParam
class (I'm open for a better name) as all param classes' (includingParam
's) superclassParam
usages to itSince 2) will require downstream projects to adopt new a new param class, it's functionally a breaking change.
And although 1) will also require changes, but it'll be on signatures only, which IMO can be argued as NOT a breaking change?
WDYT?
Required changes on Tapioca