Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add annotations for phonelib #219

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Add annotations for phonelib #219

merged 1 commit into from
Feb 8, 2024

Conversation

olivier-thatch
Copy link
Contributor

@olivier-thatch olivier-thatch commented Feb 7, 2024 •
edited
Loading

Type of Change

  • Add RBI for a new gem
  • Modify RBI for an existing gem
  • Other:

Changes

@olivier-thatch olivier-thatch requested a review from a team as a code owner February 7, 2024 19:05
@KaanOzkan KaanOzkan merged commit 58a6029 into Shopify:main Feb 8, 2024
3 checks passed
@olivier-thatch olivier-thatch deleted the olivier-phonelib branch February 8, 2024 21:45
@Morriar Morriar added the rbi Change related to RBI annotations label Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaanOzkan KaanOzkan KaanOzkan approved these changes

@egiurleo egiurleo Awaiting requested review from egiurleo egiurleo is a code owner automatically assigned from Shopify/sorbet

Assignees
No one assigned
Labels
rbi Change related to RBI annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olivier-thatch @KaanOzkan @Morriar