Raise exception on failures

Shopify · Jan 30, 2024 · 406787c · 406787c
1 parent 5cf705c
commit 406787c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/gem/exe/repo b/gem/exe/repo
@@ -105,15 +105,15 @@ module RBICentral
           if success
             log("Running Sorbet on gem...")
             $stderr.puts
-            success &= system("cd gem && bin/typecheck")
+            success &= system("cd gem && bin/typecheck", exception: true)
             $stderr.puts
             log("Running Rubocop on gem...")
             $stderr.puts
-            success &= system("cd gem && bin/style")
+            success &= system("cd gem && bin/style", exception: true)
             $stderr.puts
             log("Running gem tests...")
             $stderr.puts
-            success &= system("cd gem && bin/test")
+            success &= system("cd gem && bin/test", exception: true)
             $stderr.puts
           end
           unless success

diff --git a/gem/hooks/pre-push b/gem/hooks/pre-push
@@ -3,7 +3,7 @@
 
 $stderr.puts("Running pre-push validation...\n\n")
 
-unless system("bundle exec repo check --ref main")
+unless system("bundle exec repo check --ref main", exception: true)
   $stderr.puts("\nSome checks have failed, cancelling the push (see above)".red)
   exit(1)
 end