This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
[react-hooks] Do not throw when using useMedia in SSR without providing an initialValue #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng an initialValue
melnikov-s
force-pushed
the
use-media-fix-ssr
branch
from
b5dd2d9
to
e1aa75b
Compare
vividviolet
approved these changes
Jul 18, 2024
znja
approved these changes
Jul 18, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes (issue #)
We'll no longer throw if
initialValueis not provided in SSR, though this will result in hydration mismatch and providing aninitialValueshould be considered required for SSR, but since there's no way to enforce this at type/build time we've opted to go with this approach instead.Related discussion can be found here