Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove zero tokens #7636

Closed
wants to merge 4 commits into from
Closed

Remove zero tokens #7636

wants to merge 4 commits into from

Conversation

lgriffee
Copy link
Member

@lgriffee lgriffee commented Nov 3, 2022

WHY are these changes introduced?

Fixes #7586

WHAT is this pull request doing?

Based on our team discussion, we are removing zero tokens from our scales to provide a better experience for our developers.

TODO

  • Fix TypeScript types on Box to allow 0
  • Test and remove 0 duration token

@lgriffee lgriffee self-assigned this Nov 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

size-limit report 📦

Path Size
polaris-react-cjs 209.03 KB (-0.01% 🔽)
polaris-react-esm 135.52 KB (-0.01% 🔽)
polaris-react-esnext 191.04 KB (-0.01% 🔽)
polaris-react-css 41.7 KB (-0.04% 🔽)

@kyledurand kyledurand mentioned this pull request Nov 8, 2022
@alex-page alex-page closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants