Type tidying #2631
Merged
Type tidying #2631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pluck values from the Props interfaces instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
While rumbling through #2625 I found a bunch of cases where our components exported types that either weren't needed outside of that component, or could be made so with a bit of refactoring, and pushing usage towards referencing something living on a Props interface.
This shrinks the amount of exports in a few components.
Note that this has no effect on the types we export publicly - they all remain the same.
WHAT is this pull request doing?
Stop exporting a handful of types that weren't used outside that the file they are defined in.
Perform some refactoring so that some types are no longer used outside of the file they are defined in.
A common example is that instead of importing and using
PreferredPositionfromsrc/components/PositionedOverlay, instead importPositionedOverlayPropsand referencePositionedOverlay['preferredPosition'], at which pointPreferredPositionno longer needs to be exported.How to 🎩
Tests and type-checking pass
Note that src/components/index.ts is unmodified so our public APIs are unaffected.