[Stack] Converted to a functional component #2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given my talk in #2062 about our cargo-culty usage of PureComponent and how I'd like us to stop doing that I don't think we should bother wrapping this in a React.memo |
AndrewMusgrave
force-pushed
the
funcify-stack
branch
from
7815b30 to
eb08021
Compare
AndrewMusgrave
force-pushed
the
funcify-stack
branch
from
e619468 to
2f8cf08
Compare
|
For other readers, response to Ben here |
BPScott
reviewed
Jan 6, 2020
| }); | ||
|
|
||
| return <div className={className}>{itemMarkup}</div>; | ||
| }) as NamedExoticComponent<StackProps> & { |
There was a problem hiding this comment.
In other cases where we need this recasting it's been done at the top of the constant declaration rather than using an as, see Autocomplete for any example. Can we keep to that style for consistency?
export const Stack: React.NamedExoticComponent<StackProps> & {
Item: typeof Item;
} = function memo(function Stack({
//...There was a problem hiding this comment.
Typing is always preferred overcasting, however, unfortunately, we can't in this situation.
Type 'NamedExoticComponent<StackProps>' is not assignable to type 'NamedExoticComponent<StackProps> & { Item: ({ children, fill }: ItemProps) => Element; }'.
Property 'Item' is missing in type 'NamedExoticComponent<StackProps>' but required in type '{ Item: ({ children, fill }: ItemProps) => Element; }'There was a problem hiding this comment.
well that's a little annoying :(
/me waves fist at React.memo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
More context here
This open in a tab, will polish and request reviews after hack days.