Update to latest chromatic package #2410
Conversation
BPScott
force-pushed
the
chroma-update
branch
from
94615ce to
88bf7c3
Compare
|
💦 Potential splash zone of changes introduced to No significant changes to This comment automatically updates as changes are made to this pull request. |
BPScott
force-pushed
the
chroma-update
branch
from
88bf7c3 to
1f8b3f6
Compare
| resolved "https://registry.yarnpkg.com/cssom/-/cssom-0.4.1.tgz#b24111d236b6dbd00cdfacb5ab67a20473381fe3" | ||
| integrity sha512-6Aajq0XmukE7HdXUU6IoSWuH1H6gH9z6qmagsstTiN7cW2FNTsb+J2Chs+ufPgZCsV/yo8oaEudQLrb9dGxSVQ== | ||
|
|
||
| cssom@~0.3.6: |
There was a problem hiding this comment.
Two additional versions of cssom, wow!
There was a problem hiding this comment.
yay transitive dependencies :p
| @@ -32,7 +32,7 @@ jobs: | |||
| paths: | |||
| - node_modules | |||
| - run: yarn run test:percy | |||
| chromaui: | |||
| chroma: | |||
There was a problem hiding this comment.
Should this job be called "chromatic" for consistency? (I researched the difference between chroma and chromatic, and I am a bit confused)
There was a problem hiding this comment.
Yeah it's a bit all over the place. Chroma is the company, they make Chromatic (the VRT tool) and the early-access thing ChromaUI (the hosted storybook tool, which just got VRT stuff too), they've decided that two products is silly so once they're done with the early access stuff the "ChromaUI" brand will go away and there will be one product "Chromatic 2.0" which does both storybook hosting and VRT - this explains why this PR changes from storybook-chroma to storybook-chromatic as they've already unified their package so they have one package that handles both products while they're split and eventually storybook-chroma shall go away.
I named this chroma so it matches the name of the check that they add that links to their site, which is "ci/chroma — 264 stories published."
Move from storybook-chroma to storybook-chromatic as the package is being unified
BPScott
force-pushed
the
chroma-update
branch
from
1f8b3f6 to
b3bf881
Compare
|
|
WHY are these changes introduced?
Keeping up to date, making it easier to do new version bumps in the future now that we use their new package
WHAT is this pull request doing?
Move from storybook-chroma to storybook-chromatic as the package is
being unified
How to 🎩
See that the chroma GH check runs successfully