Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use functional components in tests #2275

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Use functional components in tests #2275

merged 1 commit into from
Oct 11, 2019

Conversation

BPScott
Copy link
Member

@BPScott BPScott commented Oct 10, 2019

WHY are these changes introduced?

Part of #1995

WHAT is this pull request doing?

Use functional components in tests

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2019 •
edited
Loading

💦 Potential splash zone of changes introduced to src/**/*.tsx in this pull request:

No significant changes to src/**/*.tsx were detected.

This comment automatically updates as changes are made to this pull request.
Feedback, troubleshooting: open an issue or reach out on Slack in #polaris-tooling.

@BPScott BPScott added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Oct 10, 2019
AndrewMusgrave
AndrewMusgrave approved these changes Oct 11, 2019
View reviewed changes
Copy link
Member

@AndrewMusgrave AndrewMusgrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@BPScott BPScott merged commit 3a61cf6 into master Oct 11, 2019
@BPScott BPScott deleted the hooks-in-test-components branch October 11, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewMusgrave AndrewMusgrave AndrewMusgrave approved these changes

Assignees
No one assigned
Labels
🤖Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BPScott @AndrewMusgrave