Hookify more components #2083
Hookify more components #2083
Conversation
| @@ -2,10 +2,7 @@ import React from 'react'; | |||
| import {CircleCancelMinor} from '@shopify/polaris-icons'; | |||
| import {ReactWrapper} from 'enzyme'; | |||
| import {mountWithAppProvider} from 'test-utilities/legacy'; | |||
| // We've got to export a named SearchField otherwise other stuff breaks | |||
There was a problem hiding this comment.
Just curious what this was breaking?
There was a problem hiding this comment.
It complained about being able to generate the types for TopBar.SearchField - or rather it was ok generating them, but trying to use it in consuming projects caused complaints. exporting SearchField in addition to the default component seemed to make it happy.
I don't understand the reasoning for it, but I seemed like it was a due to a combo of a trying to use a withAppProvider wrapped component as an exposed subcomponent
|
|
||
| interface ScrollLockProps {} | ||
|
|
||
| // Even though this has no args, reference ScrollLockProps so the prop explorer |
There was a problem hiding this comment.
Will this show up in the style guide without a Props interface?
There was a problem hiding this comment.
On second thought, looks like we don't have a readme and this is just an internal component.
There was a problem hiding this comment.
Per my proposal in #1959 we now name Props after the component - see ScrollLockProps above this. This stops us having to rename the interface when reexporting it in src/components/index.ts and src/components/ScrollLock/index.ts
The styleguide was updated to handle this in https://github.com/Shopify/polaris-styleguide/pull/2932
| }, [onCancel, onChange]); | ||
|
|
||
| useEffect(() => { | ||
| if (input.current) { |
There was a problem hiding this comment.
Small nitpick: should we have an early return so the entire effect isn't wrapped in a block?
if (!input.current) return;
focused ? input.current.focus() : input.current.blur();- RangeSlider - ScrollLock - Topbar's SearchField
As with other hookify PRs this is probably best viewed with supresed whitespace.
WHY are these changes introduced?
More work towards #1995.
WHAT is this pull request doing?
Hookifies RangeSlider, ScrollLock and Topbar's SearchField
How to 🎩