🐛[Sass] Fix recolor-icon mixin (#2298)

* 🐛 [SASS] Fix recolor-icon mixin * 📝 [CHANGELOG] Update docs
Shopify · Oct 16, 2019 · ea9733d · ea9733d
1 parent 2e0d0f9
commit ea9733d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/UNRELEASED.md b/UNRELEASED.md
@@ -15,6 +15,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
 ### Bug fixes
 
 - Doesn't render `MenuActions` if no actions are passed to an `actionGroups` item inside `Page` ([2266](https://github.com/Shopify/polaris-react/pull/2266))### Documentation
+- Fixed `recolor-icon` Sass mixin to properly scope `$secondary-color` to the child `svg` ([#2298](https://github.com/Shopify/polaris-react/pull/2298))
 
 ### Development workflow
 

diff --git a/src/styles/shared/_icons.scss b/src/styles/shared/_icons.scss
@@ -5,17 +5,17 @@
 @mixin recolor-icon($fill-color, $secondary-color: null, $filter-color: null) {
   svg {
     fill: $fill-color;
+
+    @if $secondary-color != null {
+      color: $secondary-color;
+    }
   }
 
   @if $filter-color != null {
     img {
       filter: $filter-color;
     }
   }
-
-  @if $secondary-color != null {
-    color: $secondary-color;
-  }
 }
 
 @mixin color-icon($value, $hue: base) {