Merge pull request #2076 from Shopify/fix-modal-animation

[Modal] Fixed animation issue present in async Modal rendering
Shopify · Sep 4, 2019 · df56f15 · df56f15
2 parents 066d30b + aa44f83
commit df56f15
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/UNRELEASED.md b/UNRELEASED.md
@@ -12,6 +12,8 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
 
 ### Bug fixes
 
+- Fixed animation for Modal when being rendered asynchronously ([#2076](https://github.com/Shopify/polaris-react/pull/2076))
+
 ### Documentation
 
 ### Development workflow

diff --git a/src/components/Modal/components/Dialog/Dialog.tsx b/src/components/Modal/components/Dialog/Dialog.tsx
@@ -80,6 +80,8 @@ export function Dialog({
 }
 
 const fadeUpClasses = {
+  appear: classNames(styles.animateFadeUp, styles.entering),
+  appearActive: classNames(styles.animateFadeUp, styles.entered),
   enter: classNames(styles.animateFadeUp, styles.entering),
   enterActive: classNames(styles.animateFadeUp, styles.entered),
   exit: classNames(styles.animateFadeUp, styles.exiting),