Review comments

Shopify · Sep 20, 2019 · d98c032 · d98c032
1 parent 7cd3bce
commit d98c032
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 15 deletions.
diff --git a/src/components/DatePicker/DatePicker.tsx b/src/components/DatePicker/DatePicker.tsx
@@ -66,12 +66,9 @@ export function DatePicker({
   const [hoverDate, setHoverDate] = useState<Date | undefined>(undefined);
   const [focusDate, setFocusDate] = useState<Date | undefined>(undefined);
 
-  useEffect(
-    () => {
-      setFocusDate(undefined);
-    },
-    [selected],
-  );
+  useEffect(() => {
+    setFocusDate(undefined);
+  }, [selected]);
 
   const handleFocus = useCallback((date: Date) => {
     setFocusDate(date);

diff --git a/src/components/DatePicker/components/Day/Day.tsx b/src/components/DatePicker/components/Day/Day.tsx
@@ -14,7 +14,7 @@ export interface DayProps {
   disabled?: boolean;
   onClick?(day: Date): void;
   onHover?(day?: Date): void;
-  onFocus?(day?: Date): void;
+  onFocus?(day: Date): void;
 }
 
 export function Day({
@@ -31,14 +31,11 @@ export function Day({
   const i18n = useI18n();
   const dayNode = useRef<HTMLButtonElement>(null);
 
-  useEffect(
-    () => {
-      if (focused && dayNode.current) {
-        dayNode.current.focus();
-      }
-    },
-    [focused],
-  );
+  useEffect(() => {
+    if (focused && dayNode.current) {
+      dayNode.current.focus();
+    }
+  }, [focused]);
 
   if (!day) {
     return <div className={styles.EmptyDay} onMouseOver={() => onHover(day)} />;