PR Feedback

UNRELEASED.md

@@ -25,6 +25,6 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f
 ### Code quality
 
 - Migrated `ActionMenu.RollupAction`, `Autocomplete`, `Card`, `EmptySearchResult`, `Form`, `SkeletonPage` and `TopBar` to use hooks instead of withAppProvider ([#2065](https://github.com/Shopify/polaris-react/pull/2065))
-- Added `useUniqueId` hook that can be used to get a unique id that remains consistent between rerenders and update components to use it where appropriate ([#2079](https://github.com/Shopify/polaris-react/pull/2079))
+- Added `useUniqueId` hook that can be used to get a unique id that remains consistent between rerenders and updated components to use it where appropriate ([#2079](https://github.com/Shopify/polaris-react/pull/2079))
 
 ### Deprecations

src/components/RadioButton/RadioButton.tsx

@@ -42,12 +42,12 @@ export function RadioButton({
   onChange,
   onFocus,
   onBlur,
-  id: providedId,
-  name: providedName,
+  id: idProp,
+  name: nameProp,
   value,
 }: RadioButtonProps) {
-  const id = useUniqueId('RadioButton', providedId);
-  const name = providedName || id;
+  const id = useUniqueId('RadioButton', idProp);
+  const name = nameProp || id;
 
   function handleChange({currentTarget}: React.ChangeEvent<HTMLInputElement>) {
     onChange && onChange(currentTarget.checked, id);

src/utilities/unique-id/hooks.ts

@@ -14,8 +14,7 @@ export function useUniqueId(prefix = '', override?: string) {
   // rerendering of a component
   // The first time a component is rendered the ref will be empty.
   // In that case fill it with the next available ID
-  // Only populating this on first render means we don't create a new Id on
-  // every render
+  // On subsequent renders we use the existing value instead of using a new id
   const currentComponentIdRef = useRef<string | null>(null);
 
   if (!currentComponentIdRef.current) {