Skip to content

Commit

Permalink
Merge pull request #2119 from Shopify/fix-dropzone-contrast
Browse files Browse the repository at this point in the history
[Drop zone][a11y] Fixed border colour to have better contrast
  • Loading branch information
mitchmaps authored Sep 13, 2019
2 parents cd3cf26 + 97c3896 commit 1f01f3a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions UNRELEASED.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ Use [the changelog guidelines](https://git.io/polaris-changelog-guidelines) to f

### Enhancements

- Changed border color of `Drop zone` to have better contrast from the background and to be lighter when disabled ([#2119](https://github.com/Shopify/polaris-react/pull/2119))
- Adjusted search results overlay to take up 100% height of the screen on small screens and to match the width of the search bar on large screens. ([#2103](https://github.com/Shopify/polaris-react/pull/2103))
- Added skipToContentTarget prop to Frame component ([#2080](https://github.com/Shopify/polaris-react/pull/2080))

Expand Down
7 changes: 6 additions & 1 deletion src/components/DropZone/DropZone.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@

$dropzone-padding: rem(15px);
$dropzone-border-style: dashed;
$dropzone-border-color: color('sky');
$dropzone-border-color: color('ink', 'lightest');
$dropzone-border-color-disabled: color('sky');
$dropzone-border-radius: border-radius();
$dropzone-background: color('white');
$dropzone-min-height-extra-large: rem(205px);
Expand Down Expand Up @@ -90,6 +91,10 @@ $dropzone-stacking-order: (

.isDisabled {
cursor: not-allowed;

&::after {
border-color: $dropzone-border-color-disabled;
}
}

.sizeExtraLarge {
Expand Down

0 comments on commit 1f01f3a

Please sign in to comment.