Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed access to clean_fork #86

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Conversation

ooooooo-q
Copy link
Contributor

The change of #84 had caused an error when clean_fork could not be accessed, so this has been corrected.

 ERROR -- [Pitchfork]: undefined method `clean_fork' for #<Pitchfork::HttpServer:0x0000000107a44ce8 @exit_status=0, @

@casperisfine
Copy link
Contributor

Thank. I should add a CI step that exercise these fallback paths.

@casperisfine casperisfine merged commit 8be8bc8 into Shopify:master Dec 18, 2023
5 checks passed
@ooooooo-q ooooooo-q deleted the fix/clean_fork branch December 18, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants