Improve resiliency of mold spawning #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
test-crashing-mold
branch
3 times, most recently
from
5a1c58f
to
1e62515
Compare
This is limited to the mold exiting before it acknowledged to the monitor process. This allows to sanity check the new process.
casperisfine
force-pushed
the
test-crashing-mold
branch
2 times, most recently
from
bf62a8a
to
09c1924
Compare
Ensure a mold doesn't take longer than `spawn_timeout` to be ready. If it get stuck for some reason we kill it and another one will be spawned later.
casperisfine
force-pushed
the
test-crashing-mold
branch
from
09c1924
to
3970ac1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce
spawn_timeouton molds too. If a mold takes to long to be ready, it is killed like a timing out worker and another one will be spawned later on.