Wrap enumerators to avoid JobIteration deprecation #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvasilevski
approved these changes
Dec 16, 2024
nvasilevski
reviewed
Dec 16, 2024
| @@ -75,6 +76,9 @@ def build_enumerator(_run, cursor:) | |||
| MSG | |||
| end | |||
|
|
|||
| unless @collection_enum.is_a?(JobIteration.enumerator_builder::Wrapper) | |||
There was a problem hiding this comment.
Is there a risk of Wrapper constant not existing in JobIteration.enumerator_builder namespace?
There was a problem hiding this comment.
I believe it's now part of the API. If your EnumeratorBuilder doesn't have a Wrapper constant, that line in job-iteration will raise before being able to emit the deprecation warning: https://github.com/Shopify/job-iteration/blob/v1.8.0/lib/job-iteration/iteration.rb#L223
Also I think typically one would write an EnumeratorBuilder by subclassing the one from JobIteration, so it would resolve the original wrapper in those cases.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1132
The new version of job-iteration makes CI fail because it adds a deprecation. This resolves the deprecation by always wrapping enumerators with
JobIteration.enumerator_builder.wrap.