Prefill Task parameters with query params #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianna-chang-shopify
approved these changes
Nov 21, 2024
etiennebarrie
force-pushed
the
prefill-inputs
branch
from
74e16b5 to
3b62a95
Compare
etiennebarrie
force-pushed
the
preserve-user-input
branch
from
c6a0118 to
be7f450
Compare
etiennebarrie
force-pushed
the
prefill-inputs
branch
from
3b62a95 to
9f61f8c
Compare
etiennebarrie
force-pushed
the
preserve-user-input
branch
2 times, most recently
from
5633221 to
538f09f
Compare
etiennebarrie
force-pushed
the
prefill-inputs
branch
from
9f61f8c to
7c16e41
Compare
etiennebarrie
commented
Nov 21, 2024
| @task = TaskDataShow.prepare( | ||
| params.fetch(:id), | ||
| runs_cursor: params[:cursor], | ||
| arguments: params.except(:id, :cursor, :controller, :action).permit!, |
There was a problem hiding this comment.
I just realized this prevents Tasks from having a cursor attribute, so I'll remove :cursor from this list and the cursor will be used both for the runs and the Task inputs. Which means it may end up showing an empty list of runs below the form to start a task, but I think that's ok.
Co-authored-by: Derek Meulmeester <[email protected]>
etiennebarrie
force-pushed
the
prefill-inputs
branch
from
7c16e41 to
8e2489d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been multiple attempts at adding filling the form with query params (#1046, #1051, #1113). This one uses the Run and Task objects, and solves #1116 at the same time.
This is based on #1122 and just adds what's needed to support query params filling the form.