Ignore URI::RFC3986_PARSER.escape deprecation warning #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`uri` switched the default parser from RFC2396 to RFC3986. The new parser emits a deprecation warning on a few methods and delegates them to RFC2396. See ruby/uri#114. The selenium-webdriver gem [calls `URI::RFC3986_PARSER.escape`][webdriver-callsite], which is now deprecated. Until this is fixed in selenium-webdriver, ignore the warning. [webdriver-callsite]: https://github.com/SeleniumHQ/selenium/blob/trunk/rb/lib/selenium/webdriver/remote/bridge.rb#L679
adrianna-chang-shopify
force-pushed
the
ac-ignore-uri-parser-warnings
branch
from
b3b06d5
to
9196e5f
Compare
|
Seems like there's a separate system test that's failing, will investigate 🤔 |
|
Okay, turns out the failing iframe test was actually due to the same issue, because This should be fixed now. |
nvasilevski
approved these changes
Nov 11, 2024
etiennebarrie
approved these changes
Nov 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uriswitched the default parser from RFC2396 to RFC3986. The new parser emits a deprecation warning on a few methods and delegates them to RFC2396. See ruby/uri#114.The selenium-webdriver gem calls
URI::RFC3986_PARSER.escape, which is now deprecated. Until this is fixed inselenium-webdriver, ignore the warning.Fixes failing weekly CI build: https://github.com/Shopify/maintenance_tasks/actions/runs/11769507051/job/32815543032