Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lexer parsing ID 'contains' as comparison #1840

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

ggmichaelgo
Copy link
Contributor

@ggmichaelgo ggmichaelgo commented Oct 30, 2024

With the new Lexer parser, we are always parsing contains as a comparison when it could also be an id.

Example:

Lexer.new("a.contains.b").tokenize

Expected output:

[[:id, "a"], [:dot, "."], [:id, "contains"], [:dot, "."], [:id, "b"], [:end_of_string]]

Current output

[[:id, "a"], [:dot, "."], [:comparison, "contains"], [:dot, "."], [:id, "b"], [:end_of_string]]

@ggmichaelgo ggmichaelgo requested review from ianks, a team and Maaarcocr October 30, 2024 01:24
@ggmichaelgo ggmichaelgo merged commit f6ffc37 into main Oct 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants