Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tablerow
behaves very similarly to afor
loop but does not handle interrupts. Interrupts in theBlockBody
of aTablerow
tag will stop rendering the block body but will continue to loop through the entire collection, even with pending interrupts. This is becauseTablerow
does not check for and pop interrupts.The effect of this is the full collection will be iterated and it's possible, if the first node in the
Tablerow
's body is acontinue
orbreak
, that the interrupts keep stacking (sinceBlockBody
only checks interrupts after rendering the node). This behaviour can lead to causing outer loops to prematurely exit due to stacked/leaked interrupts.In this PR, I propose we treat
Tablerow
like a loop which means it needs to pop and handle interrupts.continue
interrupts are popped but ignored because we still want to output the appropriate</tr>
strings before continuing to the next iteration.This is a small behaviour change that would shift handling interrupts inside
Tablerow
bodies to theTablerow
itself instead of aFor
loop that may enclose it. That said, I believe this is the more expected behaviour.