render template name with Liquid Syntax errors

[ggmichaelgo]

What are you trying to solve?

When there is a syntax error from a template, the Liquid error message would have a wrong filename:
Liquid:

# index
{% render 'snippet' %}

# snippet
1
2
{{ "hello world!" 

Error

Liquid syntax error (index line 3): Variable '{{' was not properly terminated with regexp: /\\}\\}/

How are you solving this?

In PartialCache, rescue Liquid errors from a Liquid#parse and assign template_name to it.

After:

Liquid syntax error (snippet line 3): Variable '{{' was not properly terminated with regexp: /\\}\\}/

[dylanahsmith]

Nitpick: This line could be moved after the rescue to make it clearer that template.parse is the only thing we need the rescue for.

[dylanahsmith]

There is at least a typo here in filename.

Also, with_actual_filename isn't really accurate, since it isn't the actual on disk file path (not does liquid itself even know that). You use with_template_name in a following test which seems more appropriate

Suggested change

	def test_syntax_error_is_raised_with_actual_filenmae
	def test_syntax_error_is_raised_with_template_name

[dylanahsmith]

Suggested change

	def test_stack_level_error_is_raised_with_actual_filenmae
	def test_stack_level_error_is_raised_with_template_name