Fix missing inheritance of disabled tags #1646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I noticed that when we subclass the Liquid::Render tag, it doesn't inherit the disabled tags or set the
@disabled_tags
instance variable on the class. This results in an internal error when the tag subclassing the Liquid::Render tag is used without the subclass also callingdisable_tags "include"
. Also, if the subclass tried to disable another tag, it could easily re-enable the tag disabled in the subclass.Solution
Use the same approach as rails'
class_attribute
of defining a method whendisable_tags
is called to override the parent'sdisabled_tags
, without the method needing to be called to inherit the parent class' method.