Support big integers in truncatewords and slice filters #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdoiron
approved these changes
Oct 11, 2022
lib/liquid/standardfilters.rb
Outdated
| raise if words + 1 < MAX_INT | ||
| # e.g. integer #{words} too big to convert to `int' | ||
| raise Liquid::ArgumentError, "integer #{words} too big for truncatewords" | ||
| # integer too big for Strin#split, but we can semantically assume no truncation is needed |
Use saturating conversion, which has expected semantics for large integers.
dylanahsmith
force-pushed
the
better-filter-overflow-handling
branch
from
047c920
to
c0c191c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a low-level implementation of liquid, I would like to treat conversion of filter arguments to
slice,truncateandtruncatewordswith a saturating conversion to an i32 or u32. Having these work consistently also allows this conversion logic to be shared across these filters.From a high-level perspective, the user would prefer if these were handled without an error for use cases like truncations and slicing. A saturating conversion seems like it would give the expected behaviour, considering that the arrays and strings themselves shouldn't be this large.
As such, I'm changing the reference implementation to adopt this behaviour.