Add a variable_name method Increment and Decrement tags objects #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to expose this state when using the parse tree.
dylanahsmith
commented
Aug 30, 2022
| end | ||
|
|
||
| def render_to_output_buffer(context, output) | ||
| value = context.environments.first[@variable] ||= 0 |
There was a problem hiding this comment.
The assignment part of ||= 0 is unnecessary, since it is assigned again after decrementing.
dylanahsmith
commented
Aug 30, 2022
| end | ||
|
|
||
| def render_to_output_buffer(context, output) | ||
| value = context.environments.first[@variable] ||= 0 | ||
| counter_environment = context.environments.first |
There was a problem hiding this comment.
I'm both highlighting the fact that this environment is treated specially in this way and reducing the redundant methods calls to use this value twice
ianks
approved these changes
Aug 30, 2022
|
cc: @Maaarcocr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to expose this state when using the parse tree, without having to resort to internal coupling like reading instance variables.