Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

fix gh action #488

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Conversation

dani-santos-code
Copy link
Contributor

This GH action is not configured as expected

This PR is to fix it

@dani-santos-code dani-santos-code force-pushed the ds/fix-gh-action-for-new-contributions branch from 6c748ed to 131da98 Compare October 6, 2022 18:27
@dani-santos-code dani-santos-code force-pushed the ds/fix-gh-action-for-new-contributions branch from 131da98 to 659c02a Compare October 6, 2022 18:29
- uses: actions/first-interaction@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
issue-message: 'Thanks for opening your first issue here! Be sure to follow the issue template!'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: do we need to set issue-message when we're only triggered on pull_request.opened?

Maybe we could skip this? or maybe we should trigger on issues.opened as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah! good point. I guess we want to do it for both PRs and Issues, since we have a message for each

I'll just confirm this and read up a bit more on the action

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! I like how we don't waste any time with a pointless actions/checkout like that example does!

Copy link
Contributor

@thepwagner thepwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

- uses: actions/first-interaction@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
issue-message: 'Thanks for opening your first issue here! Be sure to follow the issue template!'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! I like how we don't waste any time with a pointless actions/checkout like that example does!

@dani-santos-code dani-santos-code merged commit b0b5d9f into main Oct 14, 2022
@dani-santos-code dani-santos-code deleted the ds/fix-gh-action-for-new-contributions branch October 14, 2022 16:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants