-
Notifications
You must be signed in to change notification settings - Fork 184
fix gh action #488
fix gh action #488
Conversation
6c748ed
to
131da98
Compare
131da98
to
659c02a
Compare
- uses: actions/first-interaction@v1 | ||
with: | ||
repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
issue-message: 'Thanks for opening your first issue here! Be sure to follow the issue template!' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: do we need to set issue-message
when we're only triggered on pull_request.opened
?
Maybe we could skip this? or maybe we should trigger on issues.opened
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah! good point. I guess we want to do it for both PRs and Issues, since we have a message for each
I'll just confirm this and read up a bit more on the action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice! I like how we don't waste any time with a pointless actions/checkout
like that example does!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- uses: actions/first-interaction@v1 | ||
with: | ||
repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
issue-message: 'Thanks for opening your first issue here! Be sure to follow the issue template!' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice! I like how we don't waste any time with a pointless actions/checkout
like that example does!
This GH action is not configured as expected
This PR is to fix it