Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

Only show version info during version command #47

Merged
merged 1 commit into from
Oct 25, 2017

Conversation

csgregorian
Copy link
Contributor

Closes #43

Only shows server/client info during version command instead of when using -l flag.

jinankjain
jinankjain previously approved these changes Oct 25, 2017
Copy link
Contributor

@klautcomputing klautcomputing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You somehow broke it :)

@klautcomputing
Copy link
Contributor

And I figured out why: Travis doesn't have a kubeconfig, but .travis.yaml calls make version as a step. You will need to remove it from .travis.yaml

@jinankjain
Copy link
Contributor

Yeah I know why because while running test there is no kube/config

@csgregorian
Copy link
Contributor Author

I think it was just a travis problem, everything's passing now so I'll :shipit:

@csgregorian csgregorian merged commit d5b769b into master Oct 25, 2017
@csgregorian csgregorian deleted the show_version_on_version branch October 25, 2017 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants