Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

Migrate off probot-CLA to new GitHub Action #461

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

cursedcoder
Copy link
Contributor

Hello 👋

We are deprecating probot usage, so all Shopify repos should be migrated to use new GitHub CLA Action.

You can see how this works in vscode-shopify-ruby repo.

If you have any questions, please reach us on Slack.

After you merge this PR, make sure to update branch protection settings (if you have any):

  1. Go to Settings > Branches > Edit main (or any default) branch
  2. Remove the CLA check from probot (click x): image
  3. Add CLA check from GitHub action: image

** In order for the cheak to appear on the list, the workflow should be ran for at least 1 time, so after you merge this PR, add comment with text signed, then refresh the settings page.

How to trigger workflow on existing PRs:

There are few ways how to start the check on PRs created before this change:

a) Close and reopen PR:
image
b) Push empty commit to trigger the events: git commit --allow-empty -m "wakey wakey GitHub Actions"

@ghost
Copy link

ghost commented Jul 26, 2022

Thanks for opening this pull request! Please check out our contributing guidelines and sign the CLA.

Copy link
Contributor

@dani-santos-code dani-santos-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks for the context and instructions on how to proceed! 🙏

@cursedcoder cursedcoder merged commit b3342d7 into main Jul 29, 2022
@cursedcoder cursedcoder deleted the replace-cla-probot-with-action branch July 29, 2022 15:09
@ghost
Copy link

ghost commented Jul 29, 2022

Congrats on merging your first pull request, keep em coming!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants