This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
Closes: #35 check that all capabilities were dropped, inform about non-dropped caps #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klautcomputing
force-pushed
the
capability-drop-list
branch
2 times, most recently
from
78f3dd9
to
4701ea8
Compare
klautcomputing
force-pushed
the
capability-drop-list
branch
from
4701ea8
to
86de3fa
Compare
klautcomputing
commented
Oct 30, 2017
| @@ -0,0 +1 @@ | |||
| ../config | |||
There was a problem hiding this comment.
Why is there a symlink you might ask! The answer is we need the file in the tests and the executable and they are in different places and I didn't feel like writing a config for where to find the config file
klautcomputing
commented
Oct 30, 2017
| @@ -176,6 +182,12 @@ | |||
| version = "v1.0.0" | |||
|
|
|||
| [[projects]] | |||
| name = "github.com/stretchr/testify" | |||
There was a problem hiding this comment.
Does it really make sense to pull in testify when it's only used here once?! Yes, because we want to rewrite all the test!
klautcomputing
changed the title
skyhelix
approved these changes
Oct 30, 2017
| found = true | ||
| } | ||
| } | ||
| if found == false { |
There was a problem hiding this comment.
This could be if !found {, unless there's some funky javascript-esque type conversion I don't know about?
There was a problem hiding this comment.
Nope I am just old-fashioned :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we introduce the functionality to inform users about which capabilities were not dropped. There is a config file which allows users to specify the capabilities they want to drop.
#35 for reference