This repository has been archived by the owner on Oct 30, 2024. It is now read-only.
345: Fix audit config #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| func getEnabledAuditors(conf config.KubeauditConfig) []string { | ||
| auditors := []string{} | ||
| for _, auditorName := range AuditorNames { | ||
| if enabled, ok := conf.GetEnabledAuditors()[auditorName]; !ok || enabled { |
There was a problem hiding this comment.
maybe we can add a comment here to explain this line(enabled, ok := conf.GetEnabledAuditors()[auditorName]; !ok || enabled)?
// if value is not found in the `conf.GetEnabledAuditors()` map, this means
// it wasn't added to the config file, so it should be enabled by default
dani-santos-code
previously approved these changes
Jul 12, 2021
Co-authored-by: Dani <[email protected]>
dani-santos-code
previously approved these changes
Jul 13, 2021
| @@ -2,9 +2,9 @@ name: CI | |||
| on: | |||
| push: | |||
| branches: | |||
| - master | |||
| - main | |||
dani-santos-code
approved these changes
Jul 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #345
Type of change
How Has This Been Tested?
Checklist: