Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

🐛 Update dockerfile #339

Merged
merged 1 commit into from
May 18, 2021
Merged

🐛 Update dockerfile #339

merged 1 commit into from
May 18, 2021

Conversation

genevieveluyt
Copy link
Contributor

Description

As a result of recent changes which require Go 1.16 (namely, embed), the Dockerfile no longer works because it's using an older version of Go. Go release builds the binary locally and then copies it into the image so we didn't notice it before.

Fixes #338

Type of change
  • Bug fix 🐛
  • New feature ✨
  • This change requires a documentation update 📖
  • Breaking changes ⚠️
How Has This Been Tested?
  • docker build -t kubeaudit .
Checklist:
  • I have 🎩 my changes (A 🎩 specifically includes pulling down changes, setting them up, and manually testing the changed features and potential side effects to make sure nothing is broken)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The test coverage did not decrease

@ghost ghost added the readme label May 18, 2021
Copy link
Contributor

@dani-santos-code dani-santos-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix!

@genevieveluyt genevieveluyt merged commit 85c73ed into master May 18, 2021
@genevieveluyt genevieveluyt deleted the fix-docker-image branch May 18, 2021 21:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Images doesn't build correctly anymore
2 participants