This repository has been archived by the owner on Apr 27, 2021. It is now read-only.
Fix regressions from the initial pass of the upstream-hash-by annotation #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References this fallout from #5:
I had to introduce special case handling for the
upstream-hash-by
annotation on backend creation as most of the annotations are scoped to theLocation
type and injected by means of themergeLocationAnnotations
utility helper.🎩 :
Also reasoning regarding the version:
Previous version
0.9.0-beta.12-shopify
basically represents a new upstream version already available so I think this would work better:0.9.0-beta.11-shopify-<latest-feature-added>
then the version lines up with the last upstream version we're tracking
and hint @ the shopify fork and also the last feature added
eg.
0.9.0-beta.11-shopify-upstream-hash-by
@ibawt @n1koo @mkobetic @karanthukral