Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make storefrontApiVersion optional #984

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Jun 6, 2023

Both H2 and HR depend on a specific API version. This PR uses that version directly instead of requiring passing it in the parameters. The parameter is still available to overwrite it.

@frandiox frandiox requested a review from a team June 6, 2023 11:23
Copy link
Member

@benjaminsehl benjaminsehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great — awesome idea Fran. Thanks for doing this.

@frandiox frandiox merged commit 442f602 into 2023-04 Jun 7, 2023
@frandiox frandiox deleted the fd-optional-storefrontApiVersion branch June 7, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants