Add @hydrogen/remix (name TBD) #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplhomer
approved these changes
Oct 17, 2022
blittle
reviewed
Oct 17, 2022
| @@ -0,0 +1,26 @@ | |||
| import { createRequestHandler as createOxygenRequestHandler } from "@remix-run/oxygen"; | |||
There was a problem hiding this comment.
Does this mean that the graphql API helpers will only be available for Hydrogen deployments to Oxygen? Or is Hydrogen only really meant to be deployed to Oxygen in v2? cc @benjaminsehl
There was a problem hiding this comment.
It should be possible for anyone to import this function directly from @remix-run/another-provider so perhaps that simple enough?
cartogram
reviewed
Oct 17, 2022
| [key: string]: any; | ||
| }; | ||
|
|
||
| export function createStorefrontClient(clientOptions: StorefrontClientProps) { |
There was a problem hiding this comment.
Yes, it's meant to be the place where we add all of those features. I've added the storefront object that is described there to start with something.
remcolakens
added a commit
to remcolakens/hydrogen
that referenced
this pull request
Jul 14, 2023
## Context This PR has the focus on adding the new product detail page in the style of the new Code Base Theme. ## Changes - Added tailwind screen breakpoints in JS with retrievable config - Added `@remix-eslint-config` - Added PDP page with all UX-elements in place by the new CBT design - Added: `ts-reset` to have more mainstream TypeScript properties and solving known issues - Added: New prop `availableForSale` on ProductCard - Added: `product-features` component for a list of features - Added: `product-gallery` component for a displaying media content on the PDP - Added: `VariantSelector` component for selecting your product's variant - Added `product-mapper` for mapping all Shopify data into a managable object - Refactor: root page with unused query - Refactor: Made better object for ProductGrid without the nested props - Refactor: Moved away from hardcoded (grid) values and load them in by using a helper - Refactor: Use the `import type` for types (new linting rule) - Refactor: return null when object can be possible empty (new linting rule) - Refactor: use dynamic breakpoints for the img sizes - Refactor: renamed variable `name` to `title` for `<HydrogenImage /> - Refactor: Make props of `<ProductCard />` more in line with Shopify by renaming brand to vendor and name to title - Fixed: grid issue for collection page on mobile devices - Fixed: homePageFeaturedProducts.json mock file - Fixed: Issue with accordion package where border was not correct - Fixed: Issue with button where focus color was not correct ## Screenshot  ## Paperwork [SCH-49](https://codeinternetapplications.atlassian.net/browse/SCH-49) [SCH-112](https://codeinternetapplications.atlassian.net/browse/SCH-112) [SCH-47](https://codeinternetapplications.atlassian.net/browse/SCH-47) ## Checklist - [x] My code follows the style guidelines of this project - [x] I've performed a self-review of my own code - [x] I've added a changeset if this PR contains user-facing or noteworthy changes - [x] I've commented my code, particularly in hard-to-understand areas - [x] I've made corresponding changes to the documentation - [x] I've tested my code for breaking changes and added the corresponding footer in this PR if needed [SCH-49]: https://codeinternetapplications.atlassian.net/browse/SCH-49?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [SCH-112]: https://codeinternetapplications.atlassian.net/browse/SCH-112?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [SCH-47]: https://codeinternetapplications.atlassian.net/browse/SCH-47?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of #73 and adds a new
@hydrogen/remixpackage where we can place all the Hydrogen logic for Remix.TODO: replace
data/index.tsto start using the newstorefrontclient.Is this somewhat close to the package organization we want to have? I think some stuff here overlaps with the current Hydrogen UI.