Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto cookie domain detect and update analytics error message #2256

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

wizardlyhel
Copy link
Contributor

@wizardlyhel wizardlyhel commented Jun 17, 2024

WHY are these changes introduced?

  • Fix consent setting not persisting when both shop and checkout are both subdomains
  • Update analytics error messages to be more informative

HOW to test your changes?

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

This comment has been minimized.

Copy link
Contributor

shopify bot commented Jun 17, 2024

Oxygen deployed a preview of your hl-analytics-minior-tweak branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment June 18, 2024 3:58 PM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment June 18, 2024 3:59 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment June 18, 2024 3:58 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment June 18, 2024 3:58 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment June 18, 2024 3:58 PM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment June 18, 2024 3:58 PM

Learn more about Hydrogen's GitHub integration.

.changeset/stupid-falcons-wash.md Outdated Show resolved Hide resolved
@wizardlyhel wizardlyhel merged commit 6cd5554 into main Jun 18, 2024
13 checks passed
@wizardlyhel wizardlyhel deleted the hl-analytics-minior-tweak branch June 18, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants