AuthBypassTokenDuration CLI Additions #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
|
Please rebase when #2192 is merged 🙏 |
NelsonLee-Code
force-pushed
the
AuthBypassTokenDuration-CLI-Additions
branch
3 times, most recently
from
3b03fc9 to
0c6833b
Compare
NelsonLee-Code
requested review from
graygilmore,
aswamy and
a team
and removed request for
graygilmore
aswamy
reviewed
Jun 6, 2024
| @@ -226,6 +233,7 @@ export async function runDeploy( | |||
| options: OxygenDeploymentOptions, | |||
| ): Promise<void> { | |||
| const { | |||
| authBypassTokenDuration: authBypassTokenDuration, | |||
There was a problem hiding this comment.
Suggested change
| authBypassTokenDuration: authBypassTokenDuration, | |
| authBypassTokenDuration, |
NelsonLee-Code
force-pushed
the
AuthBypassTokenDuration-CLI-Additions
branch
2 times, most recently
from
494ef9e to
18b11a7
Compare
frandiox
approved these changes
Jun 7, 2024
| description: | ||
| 'Specify the duration (in hours) up to 12 hours for the authentication bypass token. Defaults to `2`', | ||
| required: false, | ||
| dependsOn: ['auth-bypass-token'], |
There was a problem hiding this comment.
It might be useful to add an env flag name to both auth-bypass-token and auth-bypass-token-duration so that devs can pass these values from env variables.
| authBypassTokenDuration: '2', | ||
| }; | ||
|
|
||
| await runDeploy(params); |
There was a problem hiding this comment.
To get better errors:
Suggested change
| await runDeploy(params); | |
| await expect(runDeploy(params)).resolves.not.toThrow(); |
NelsonLee-Code
force-pushed
the
AuthBypassTokenDuration-CLI-Additions
branch
2 times, most recently
from
bc133cb to
8f105df
Compare
NelsonLee-Code
force-pushed
the
AuthBypassTokenDuration-CLI-Additions
branch
from
8f105df to
e1969ad
Compare
graygilmore
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Issue: Issue
Added the
-auth-bypass-token-durationflag in the Hydrogen CLI to allow developers to extend E2E tests via their auth-bypass-token.By default, tokens are valid for two hours. You can modify this duration by supplying the
--auth-bypass-token-durationflag to thedeploycommand. The duration can be set to any whole number of hours from 1 to 12.npx shopify hydrogen deploy --auth-bypass-token --auth-bypass-token-duration=5 --token $SHOPIFY_HYDROGEN_DEPLOYMENT_TOKENDocs: https://github.com/Shopify/shopify-dev/pull/44952
WHAT is this pull request doing?
-auth-bypass-token-durationflag in the Hydrogen CLI.HOW to test your changes?
I added the an auth-bypass-token-duration of 5 hours, which succeeded in deploying to Oxygen and the token expires 5 hours from when it was created.
Post-merge steps
Checklist