Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't filter product options with only one value in the VariantSelector #2113

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

blittle
Copy link
Contributor

@blittle blittle commented May 14, 2024

WHY are these changes introduced?

We are in the process of simplifying and improving the components offered by Hydrogen. As a part of that, it's been requested that the VariantSelector component be changed to not filter out options that have only one value. This is a breaking change.

See the changeset for an example on how to migrate.

Fixes #1198

HOW to test your changes?

  1. Make sure that the skeleton template does not display product options for a product that does not have more than one value. For example: /products/shopify-wax

Post-merge steps

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes
  • I've added tests to cover my changes
  • I've added or updated the documentation

Copy link
Contributor

shopify bot commented May 14, 2024

Oxygen deployed a preview of your bl-variant-selector-filter branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
subscriptions ✅ Successful (Logs) Preview deployment Inspect deployment June 12, 2024 8:56 PM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment June 12, 2024 8:56 PM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment June 12, 2024 8:56 PM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment June 12, 2024 8:56 PM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment June 12, 2024 8:56 PM
vite ✅ Successful (Logs) Preview deployment Inspect deployment June 12, 2024 8:56 PM

Learn more about Hydrogen's GitHub integration.

Copy link
Contributor

@frandiox frandiox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right fix 👍

Should we wait to merge this when preparing for the next major? It's a small change so probably we won't have conflicts.

@blittle
Copy link
Contributor Author

blittle commented May 15, 2024

Okay, I'll hold off merging.

@blittle blittle added the 2024.7 label May 29, 2024
@blittle blittle force-pushed the bl-variant-selector-filter branch from 71db4bb to cde3328 Compare June 12, 2024 20:54
@blittle blittle merged commit 8b9c726 into main Jun 12, 2024
13 checks passed
@blittle blittle deleted the bl-variant-selector-filter branch June 12, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants