List the uncommitted files that the deploy command errors on #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graygilmore
commented
Apr 4, 2024
vincentezw
approved these changes
Apr 5, 2024
frandiox
approved these changes
Apr 5, 2024
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
graygilmore
force-pushed
the
gg-list-uncommitted-changes
branch
from
2b0188e
to
b11c1dc
Compare
graygilmore
commented
Apr 8, 2024
Comment on lines
-43
to
-49
| vi.mock('@shopify/cli-kit/node/output', async () => { | ||
| return { | ||
| outputContent: () => ({value: ''}), | ||
| outputInfo: () => {}, | ||
| outputWarn: () => {}, | ||
| }; | ||
| }); |
There was a problem hiding this comment.
These weren't being mocked in any way so I'm removing this.
frandiox
approved these changes
Apr 9, 2024
graygilmore
force-pushed
the
gg-list-uncommitted-changes
branch
from
b11c1dc
to
fa9128e
Compare
Force Push Patch Notes
|
martinamarien
approved these changes
Apr 9, 2024
graygilmore
force-pushed
the
gg-list-uncommitted-changes
branch
from
fa9128e
to
8e4d171
Compare
Force Push Patch Notes
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Now that we're guiding merchants to use the
deploycommand a number of them are hitting an error that they haven't seen before:This is easy to debug locally because you can run
git statusto see what has changed but it's cumbersome when it's only happening in your CI environment. The most likely cause of this is that their package manager's lockfile is being updated during the dependency installation process but it's not easy to tell.WHAT is this pull request doing?
This PR updates the error message to include all of the file changes by capturing the changes with
git status -sand adding them to the banner. For example, while working on this change locally I had the following output:Additionally if we find that there are lockfiles present in the diff we'll add an additional item in "next steps" to explain how you might be able to avoid those files changing during a CI deploy.
Checklist