fix: fixed Pagination, NextLink and PreviousLink return types

[lorenzo-del-rosario]

Fixing Pagination, PreviousLink and NextLink returning an invalid JSX element type.

Error:

'Pagination' cannot be used as a JSX component.
  Its type '<NodesType>({ connection, children, }: PaginationProps<NodesType>) => ReactNode' is not a valid JSX element type.
    Type '<NodesType>({ connection, children, }: PaginationProps<NodesType>) => ReactNode' is not assignable to type '(props: any) => ReactElement<any, any> | null'.
      Type 'ReactNode' is not assignable to type 'ReactElement<any, any> | null'.
        Type 'undefined' is not assignable to type 'ReactElement<any, any> | null'.

Dependencies:

    "@remix-run/react": "2.1.0",
    "@shopify/cli": "3.52.0",
    "@shopify/cli-hydrogen": "^7.0.0",
    "@shopify/hydrogen": "^2024.1.0",
    "@shopify/remix-oxygen": "^2.0.3",
    "react": "^18.2.0",
    "react-dom": "^18.2.0",

WHAT is this pull request doing?

ChangesPagination, PreviousLink and NextLink types to rely on the React FunctionalComponent type to give a more consistent typing and align better to React types.

HOW to test your changes?

Post-merge steps

Checklist

• I've read the Contributing Guidelines
• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've added a changeset if this PR contains user-facing or noteworthy changes
• I've added tests to cover my changes
• I've added or updated the documentation

[lorenzo-del-rosario]

I have signed the CLA!

[frandiox]

Thanks!

@blittle I think this is probably correct, right?

[lorenzo-del-rosario]

@frandiox am I required to do something else for the PR to be merged?

[blittle]

Thank you!