Fix storefront api cache key #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanpprieto
approved these changes
Sep 26, 2023
blittle
reviewed
Sep 26, 2023
| const [body, response] = await fetchWithServerCache(url, requestInit, { | ||
| cacheInstance: mutation ? undefined : cache, | ||
| cache: cacheOptions || CacheShort(), | ||
| cacheKey, |
There was a problem hiding this comment.
NIT, but maybe it's worth making cacheKey a required option, without a default that could easily include a bad init.
There was a problem hiding this comment.
it's optional with createWithCache. If we want to make it required, it'll have to be a calendar release
blittle
approved these changes
Sep 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Improves Storefront API cache performance
WHAT is this pull request doing?
HOW to test your changes?
Post-merge steps
Checklist