return typed data from product and collection SEO utilities (#763)

Shopify · Apr 6, 2023 · 0f4d562 · 0f4d562
1 parent 91f0ff4
commit 0f4d562
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/small-elephants-jam.md b/.changeset/small-elephants-jam.md
@@ -0,0 +1,5 @@
+---
+'@shopify/cli-hydrogen': patch
+---
+
+Improve type safety in SEO data generators.
diff --git a/templates/demo-store/app/lib/seo.server.ts b/templates/demo-store/app/lib/seo.server.ts
@@ -85,7 +85,7 @@ function productJsonLd({
   product: Product;
   selectedVariant: ProductVariant;
   url: Request['url'];
-}): SeoConfig<SeoProduct | BreadcrumbList>['jsonLd'][] {
+}): SeoConfig<SeoProduct | BreadcrumbList>['jsonLd'] {
   const origin = new URL(url).origin;
   const variants = product.variants.nodes;
   const description = truncate(
@@ -152,7 +152,7 @@ function product({
   product: Product;
   selectedVariant: ProductVariant;
   url: Request['url'];
-}) {
+}): SeoConfig<SeoProduct | BreadcrumbList> {
   const description = truncate(
     product?.seo?.description ?? product?.description ?? '',
   );
@@ -170,7 +170,7 @@ function collectionJsonLd({
 }: {
   url: Request['url'];
   collection: Collection;
-}): SeoConfig<CollectionPage | BreadcrumbList>['jsonLd'][] {
+}): SeoConfig<CollectionPage | BreadcrumbList>['jsonLd'] {
   const siteUrl = new URL(url);
   const itemListElement: CollectionPage['mainEntity'] =
     collection.products.nodes.map((product, index) => {
@@ -222,7 +222,7 @@ function collection({
 }: {
   collection: Collection;
   url: Request['url'];
-}) {
+}): SeoConfig<CollectionPage | BreadcrumbList> {
   return {
     title: collection?.seo?.title,
     description: truncate(