Adds dynamic screen height to Tailwind for Cart Drawer #2102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today the cart drawer uses
svh
when supported, as the height. This means that if the user has scrolled, the cart drawer will not fill the page (see screenshot).We still want to keep
svh
as the main way to interact withh-screen
as it's most often used for full bleed Hero banners (and similar) where you don't want the height to change (too jarring). However specifically on the cart drawer, this should be dynamic, as you can only scroll within the pane when it's open.This also updates
@headlessui
to 1.7.0 to resolve a bug found in scroll lock: tailwindlabs/headlessui#949Before submitting the PR, please make sure you do the following:
fixes #123
)yarn changeset add
if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning