Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank space still exists #868

Open
lekbit opened this issue Jul 4, 2023 · 18 comments
Open

Blank space still exists #868

lekbit opened this issue Jul 4, 2023 · 18 comments
Labels
bug Something isn't working

Comments

@lekbit
Copy link

lekbit commented Jul 4, 2023

Perhaps the FlashList developers expect us to set a limit on scrolling at once, or is there something I don't know?

Current behavior

screenrecorder-2023-07-04-13-55-53-302.mp4

Expected behavior

Don't see blank space.

To Reproduce

import React from "react";
import { View, Text, StatusBar } from "react-native";
import { FlashList } from "@shopify/flash-list";

const DATA = [
  {
    title: "First Item",
  },
  {
    title: "Second Item",
  },
];

export default function MyList() {
  for (let index = 0; index < 500; index++) {
    DATA.push({
      title: "First Item" + index,
    })
  }
  return (
    <FlashList
      data={DATA}
      renderItem={({ item }) => <Text>{item.title}</Text>}
      estimatedItemSize={200}
    />
  );
};

Platform:

  • Android

Environment

"@shopify/flash-list": "^1.4.3"
@lekbit lekbit added the bug Something isn't working label Jul 4, 2023
@vagnerlandio
Copy link

vagnerlandio commented Jul 10, 2023

FlashList expect a correct estimatedItemSize value based on the rendered item height

@lekbit
Copy link
Author

lekbit commented Jul 10, 2023

FlashList expect a correct estimatedItemSize value based on the rendered item height

Now my values ​​are set correctly?

screen-recording.Ready.mp4

@SohelIslamImran
Copy link

I still couldn't use FlashList because of this issue. This experience is worse than FlatList.

@rokkoo
Copy link

rokkoo commented Jul 13, 2023

Im also trying to fix this problem, let us know is you fix it or something, thanks!

@lekbit
Copy link
Author

lekbit commented Aug 4, 2023

Alright, guys, I was wrong. Well, to be precise, it wasn't mentioned anywhere, but after compiling the release version of the project into bundle .abb file, I installed it on the phone, and it worked quite well.

flashLRecord.mp4

@coofzilla
Copy link

coofzilla commented Aug 23, 2023

I'm having the same issue. built it on my phone and still had the blanks even with setting the estimatedItemSize to the exact height of the component to render.

However, in my case, I also have a component that takes up height but isn't actually visible until a certain action is performed. When I removed that, it worked fine; so, I'm not sure if the calculation of the height should include items that exist on the render but aren't physically present. To clarify, this hidden component just has an opacity of 0 until action then its 1.

@pavelustenko
Copy link

As far as I can see, the flashlist is good for lists with the same element height. If you have elements of different heights, then glitches and blanks begin when scrolling (mostly in release mode on low-end (Quallcom 4 cores, 4Gb ram) android phones). I couldnt get it fixed by guessing estimated size of even scroll decelleration.
:( So I went back to Flatlist.

@itajenglish
Copy link

+1

@lucasmachadoalvino
Copy link

+1

@iway1
Copy link

iway1 commented Dec 27, 2023

FlashList expect a correct estimatedItemSize value based on the rendered item height

No it doesn't (or it shouldn't according to docs). Docs specifically say "Doesn't have to be very accurate"

@dippathak1912
Copy link

Have the same issue.

"@shopify/flash-list": "^1.5.0",
"react-native": "^0.70.1",
"react": "18.1.0"

Is there any way out of this?

@zoobibackups
Copy link

I have created a contact list of about 1000 users. it has still issues in release versions. I have to create a release apk.

Screenrecorder-2024-01-02-15-09-05-126.mp4

@Med-Amine-Fredj
Copy link

+1

hyoban added a commit to hyoban/follow-app that referenced this issue Aug 3, 2024
@orlynbsd
Copy link

orlynbsd commented Sep 6, 2024

under the hood they are using recyclerlistview from Flipkart
and have same issue

Flipkart/recyclerlistview#716

@ZaharGusyatin
Copy link

any solutions?

@csulit
Copy link

csulit commented Oct 2, 2024

Same issue

@ZaharGusyatin
Copy link

say goodbye Shopify

@mahaaoo
Copy link

mahaaoo commented Oct 11, 2024

Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests