Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow laquo and raquo in HardCodedString linter #355

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Allow laquo and raquo in HardCodedString linter #355

merged 1 commit into from
Sep 18, 2024

Conversation

bcroesch
Copy link
Contributor

Adds « and » to the NO_TRANSLATION_NEEDED set in the HardCodedString linter

@bcroesch
Copy link
Contributor Author

I have signed the CLA!

@etiennebarrie etiennebarrie merged commit 8a6c502 into Shopify:main Sep 18, 2024
1 check passed
@Mangara Mangara mentioned this pull request Oct 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebarrie etiennebarrie etiennebarrie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcroesch @etiennebarrie